You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having just one MoveOperation with different type property value might simplify some places in the code. Right now, RemoveOperation and ReinsertOperation extends MoveOperation but aren't much different from it.
The text was updated successfully, but these errors were encountered:
scofalik
changed the title
[OT] Followup: Have just one MoveOperation
Have just one MoveOperation
Jul 24, 2018
Other: Moved error logging from debug tools to OT code.
Other: Aligned `Schema#getValidRanges` results to changes in `AttributeOperation`.
Other: Unified `RemoveOperation` and `ReinsertOperation` to have just one `MoveOperation`.
Other: Simplified `LiveRange#event:change` second parameter which is now an object containing `Position` not an `Operation`.
Internal: Operational transformations refactor followups.
Internal: Additional improvements for the new OT algorithms.
Internal: Added relations to better solve cases in undo.
Internal: Improved cloning mechanism inside `WrapOperation`.
Internal: Improved `model.Range#getTransformedByMergeOperation`.
Internal: Other improvements in OT algorithms.
Internal: Improvements in docs.
Closes #1468. Closes #1464. Closes #1467. Closes #1460. Closes #1461. Closes #1462. Closes #1463. Closes #1475. Closes #1479.
BREAKING CHANGE: `LiveRange#event:change` second parameter is now an object containing property `deletionPosition`. It can be `model.Position` instance, if the range was moved to the graveyard root. The position is equal to the position from which nodes were removed. Otherwise, it is set to `null`.
BREAKING CHANGE: `Schema#getValidRanges` will return only flat ranges now. If an attribute is allowed on some nodes and in those nodes children, multiple "nested" ranges will be returned.
BREAKING CHANGE: `Schema#getValidRanges` is a generator now.
mlewand
transferred this issue from ckeditor/ckeditor5-engine
Oct 9, 2019
This is a follow-up after OT refactor PR:
ckeditor/ckeditor5-engine#1459
Having just one
MoveOperation
with differenttype
property value might simplify some places in the code. Right now,RemoveOperation
andReinsertOperation
extendsMoveOperation
but aren't much different from it.The text was updated successfully, but these errors were encountered: