This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
OT refactor followups #1497
Merged
OT refactor followups #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the new AttributeOperation.
…nPosition` not operation that changed the range.
…d stick to the node they "represent".
…pecial case of unwrapping a node that is already in the graveyard.
# Conflicts: # src/model/operation/transform.js
# Conflicts: # tests/model/operation/transform.js
# Conflicts: # src/model/operation/transform.js # tests/dev-utils/enableenginedebug.js # tests/model/operation/transform.js
# Conflicts: # tests/model/operation/transform.js
|
Although changes from branch |
|
I've pushed some fixes but they broke the CI. For sure one of the problems is that now |
This was referenced Aug 9, 2018
Closed
|
ckeditor/ckeditor5-undo#90 Okay I am stupid, tests are failing in engine too cause engine uses undo -_- |
This was referenced Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Additional improvements for the new OT algorithms. Added relations to better solve cases in undo. Moved error logging from debug tools to OT code. Improved cloning mechanism inside
WrapOperation. AlignedSchema#getValidRangesresults to changes inAttributeOperation. UnifiedRemoveOperationandReinsertOperationto have just oneMoveOperation. Improvedmodel.Range#getTransformedByMergeOperation. SimplifiedLiveRange#event:changesecond parameter which is now an object containingPositionnot anOperation. Other improvements in OT algorithms. Improvements in docs. Closes ckeditor/ckeditor5#4383. Closes ckeditor/ckeditor5#4379. Closes ckeditor/ckeditor5#4382. Closes ckeditor/ckeditor5#4375. Closes ckeditor/ckeditor5#4376. Closes ckeditor/ckeditor5#4377. Closes ckeditor/ckeditor5#4378. Closes ckeditor/ckeditor5#4390. Closes ckeditor/ckeditor5#4393.BREAKING CHANGE:
LiveRange#event:changesecond parameter is now an object containing propertydeletionPosition. It can bemodel.Positioninstance, if the range was moved to the graveyard root. The position is equal to the position from which nodes were removed. Otherwise, it is set tonull.BREAKING CHANGE:
Schema#getValidRangeswill return only flat ranges now. If an attribute is allowed on some nodes and in those nodes children, multiple "nested" ranges will be returned.BREAKING CHANGE:
Schema#getValidRangesis a generator now.