New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all Webpack usage to Webpack 3 #475

Closed
Reinmar opened this Issue Jun 20, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@Reinmar
Copy link
Member

Reinmar commented Jun 20, 2017

Release notes: https://medium.com/webpack/webpack-3-official-release-15fd2dd8f07b

Interesting to check:

  • Module concatenation – we should check it in ckeditor5-build-classic. Hopefully, it will improve the bundle size. As for Webpack use in other places... I think that we could also introduce this plugin, but I'd check if it doesn't affect the performance. The performance will count the most in automated tests, so in manual tests we can lose more. Ideally, we should have the same configuration everywhere so we test with the production setup.
  • "Better Build Caching" and "Faster initial and incremental builds" sounds like there might be some changes in the memory consumption – I hope that not for worse.
@pomek

This comment has been minimized.

Copy link
Member

pomek commented Oct 16, 2017

Bundle size with and without module concatenation:

  • with: 381307B (372K),
  • without: 420550B (411K).

So we could use it.

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Oct 16, 2017

Nice! And gzipped size (which is the one which matters)?

@pomek

This comment has been minimized.

Copy link
Member

pomek commented Oct 17, 2017

Gzipped size:

  • with: 101216B (99K),
  • without: 112131B (110K).

Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Nov 10, 2017

Merge pull request #28 from ckeditor/t/ckeditor5/475
Other: Optimized the bundle size (~10%) by enabling webpack's `ModuleConcatenationPlugin` plugin. Read more ckeditor/ckeditor5#475.

Reinmar added a commit to ckeditor/ckeditor5-build-inline that referenced this issue Nov 10, 2017

Merge pull request #2 from ckeditor/t/ckeditor5/475
Other: Optimized the bundle size (~10%) by enabling webpack's `ModuleConcatenationPlugin` plugin. Read more ckeditor/ckeditor5#475.

Reinmar added a commit to ckeditor/ckeditor5-build-balloon that referenced this issue Nov 10, 2017

Merge pull request #2 from ckeditor/t/ckeditor5/475
Other: Optimized the bundle size (~10%) by enabling webpack's `ModuleConcatenationPlugin` plugin. Read more ckeditor/ckeditor5#475.

@Reinmar Reinmar closed this Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment