Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "select entire column" and "select entire row" options in the row/col dropdowns #6500

Closed
7 tasks
Reinmar opened this issue Mar 26, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#295
Closed
7 tasks
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 26, 2020

📝 Provide a description of the new feature

Before we'll have #6276 let's have simple items in the row and col dropdowns to achieve the same result.

Steps required to achieve above:

  • create commands for selecting column or row
    • commands should work with collapsed selection inside table cell
    • commands should work with multi-cell selection
    • commands should be disabled when selection is outside table or a whole table is selected
  • create UI buttons for given commands
  • tests
  • API docs (in code), feature docs (what commands are available)

Tricky parts (needs tests): spanned cells. I'd go with simplest solution and emulate with a command behaviour of what would user do with mouse. So no "smart" selections that would select more then selected table cell's parent row:

would select:

This task might be split to two task (for each command) this way we can review earlier and probably those commands will not share code (will share with other commands).


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@Reinmar Reinmar added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:table domain:ui/ux This issue reports a problem related to UI or UX. labels Mar 26, 2020
@Reinmar Reinmar added this to the iteration 31 milestone Mar 26, 2020
jodator added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 6, 2020
Feature: "Select entire column/row" added to table column and row dropdowns. Closes ckeditor/ckeditor5#6500.
mlewand pushed a commit that referenced this issue May 1, 2020
Feature: "Select entire column/row" added to table column and row dropdowns. Closes #6500.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants