Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages in case of missing translations #666

Closed
wwalc opened this issue Nov 15, 2017 · 5 comments
Closed

Improve error messages in case of missing translations #666

wwalc opened this issue Nov 15, 2017 · 5 comments
Assignees
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@wwalc
Copy link
Member

wwalc commented Nov 15, 2017

🐞 Is this a bug report or feature request? (choose one)

  • Bug report 😈

πŸ’» Version of CKEditor

1.0.0-alpha.2

πŸ“‹ Steps to reproduce

  1. Create documentation for CKEditor 5 with Umberto.

βœ… Expected result

Better information about where precisely the translation is missing and for which language. I may be interested only in certain languages and be fine with missing translations in other languages.

❎ Actual result

screen shot 2017-11-15 at 14 35 28

πŸ“ƒ Other details that might be useful

@ma2ciek
Copy link
Contributor

ma2ciek commented Nov 15, 2017

That should be fixed by the #624. The language will be added to the error message.

@ma2ciek ma2ciek self-assigned this Nov 15, 2017
@ma2ciek ma2ciek added this to the iteration 14 milestone Nov 15, 2017
@ma2ciek ma2ciek added the type:bug This issue reports a buggy (incorrect) behavior. label Nov 15, 2017
@ma2ciek
Copy link
Contributor

ma2ciek commented Nov 28, 2017

Hmm, after changes in the #624, there will be a lot of errors for the default build (additionalLanguages: all). Do we want to collect those errors and display something like this: "Not found 13 translations for 'de' language."? On the other hand, that label won't be very helpful.

cc @Reinmar @szymonkups

@Reinmar
Copy link
Member

Reinmar commented Nov 28, 2017

But those warnings should only be logged if you chose a specific language. If you build for 'all' they make little sense because you're not interested in 99% of those languages. In fact... perhaps these warnings make no sense at all?

@ma2ciek
Copy link
Contributor

ma2ciek commented Nov 28, 2017

In fact... perhaps these warnings make no sense at all?

I was thinking about this, but the fact, that some translations are missing should be important for the developer, at least, when he selects one target language. But I know, he can't do anything at this stage... (despite adding the missing translation on Transifex :D)

These errors (or stats) makes perfect sense after downloading translations from Transifex.

@Reinmar
Copy link
Member

Reinmar commented Nov 29, 2017

Let's do this:

  • by default 0 warnings should be logged as they don't make sense most of the time,
  • but you should be able to turn on a verbose mode in the plugin and in such a case it should log everything.

szymonkups added a commit to ckeditor/ckeditor5-dev that referenced this issue Nov 30, 2017
Feature: Implement TranslationService v2 (ckeditor5-dev part). Closes ckeditor/ckeditor5#666. Closes ckeditor/ckeditor5#624.

BREAKING CHANGE: `CKEditorWebpackPlugin` plugin supports now `language` and `additionalLanguages` options instead of `languages`. If only `language` is set, the plugin will translate code directly into the main bundle. When `additionalLanguages` are provided, then the plugin will output bundle with the main language and rest translation files separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants