-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages in case of missing translations #666
Comments
That should be fixed by the #624. The language will be added to the error message. |
Hmm, after changes in the #624, there will be a lot of errors for the default build ( |
But those warnings should only be logged if you chose a specific language. If you build for 'all' they make little sense because you're not interested in 99% of those languages. In fact... perhaps these warnings make no sense at all? |
I was thinking about this, but the fact, that some translations are missing should be important for the developer, at least, when he selects one target language. But I know, he can't do anything at this stage... (despite adding the missing translation on Transifex :D) These errors (or stats) makes perfect sense after downloading translations from Transifex. |
Let's do this:
|
Feature: Implement TranslationService v2 (ckeditor5-dev part). Closes ckeditor/ckeditor5#666. Closes ckeditor/ckeditor5#624. BREAKING CHANGE: `CKEditorWebpackPlugin` plugin supports now `language` and `additionalLanguages` options instead of `languages`. If only `language` is set, the plugin will translate code directly into the main bundle. When `additionalLanguages` are provided, then the plugin will output bundle with the main language and rest translation files separately.
π Is this a bug report or feature request? (choose one)
π» Version of CKEditor
1.0.0-alpha.2
π Steps to reproduce
β Expected result
Better information about where precisely the translation is missing and for which language. I may be interested only in certain languages and be fine with missing translations in other languages.
β Actual result
π Other details that might be useful
The text was updated successfully, but these errors were encountered: