Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation of autolink #8050

Closed
panr opened this issue Sep 9, 2020 · 0 comments · Fixed by #9070
Closed

Improve validation of autolink #8050

panr opened this issue Sep 9, 2020 · 0 comments · Fixed by #9070
Assignees
@pkwasnik
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 40 (v26...

Comments

@panr
Copy link
Contributor

panr commented Sep 9, 2020 •
edited

📝 Provide detailed reproduction steps (if any)

Followup to #8044 (comment)

  1. Open an editor with AutoLink plugin enabled.
  2. Paste the following text: https://www.cksource.com
  3. Select for example the urce.com (https://www.ckso[urce.com]) part of the text and press enter key.

✔️ Expected result

Selection should move to the newly created paragraph without transforming the https://www.ckso to the link.

❌ Actual result

Selection creates a new paragraph but also the https://www.ckso text transforms to the link.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@panr panr added type:bug This issue reports a buggy (incorrect) behavior. domain:ui/ux This issue reports a problem related to UI or UX. package:link squad:core Issue to be handled by the Core team. labels Sep 9, 2020
@panr panr modified the milestone: iteration 36 Sep 9, 2020
@Reinmar Reinmar added this to the next milestone Sep 11, 2020
@pomek pomek modified the milestones: next, nice-to-have Nov 10, 2020
@pkwasnik pkwasnik self-assigned this Feb 19, 2021
@pkwasnik pkwasnik mentioned this issue Feb 22, 2021
Merged
mlewand added a commit that referenced this issue Feb 23, 2021
@mlewand
Merge pull request #9070 from ckeditor/i/8050
2165447 
Fix (link): Autolink will no longer automatically match domains that only have a `www` subdomain followed with a top level domain, e.g. `http://www.test`. Closes #8050.
@mlewand mlewand modified the milestones: nice-to-have, iteration 40 Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 40 (v26.0.0)
Development

Successfully merging a pull request may close this issue.

Improved validation of autolink ckeditor/ckeditor5
5 participants
@Reinmar @panr @pomek @mlewand @pkwasnik