Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting large content freezes the editor #8188

Closed
FilipTokarski opened this issue Sep 30, 2020 · 5 comments · Fixed by #8620
Closed

Formatting large content freezes the editor #8188

FilipTokarski opened this issue Sep 30, 2020 · 5 comments · Fixed by #8620
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:performance This issue reports a performance issue or a possible performance improvement.

Comments

@FilipTokarski
Copy link
Member

FilipTokarski commented Sep 30, 2020

📝 Provide detailed reproduction steps (if any)

  1. Add some large content to editor ( I'm using the one from pagination demo )
  2. Select all
  3. Change font size/ apply bold / apply some other formatting

✔️ Expected result

Formatting happens immediately.

❌ Actual result

Editor freezes, sometimes for more than ~30 seconds:

0_freeze1

📃 Other details

  • Browser: Chrome, Firefox
  • On Safari the freeze is almost unnoticeable
  • CKEditor version: old issue, happens even on v15

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:font labels Sep 30, 2020
@FilipTokarski FilipTokarski changed the title Changing font size on large content freezes the editor Formatting large content freezes the editor Sep 30, 2020
@FilipTokarski FilipTokarski added type:performance This issue reports a performance issue or a possible performance improvement. and removed package:font labels Sep 30, 2020
@Mgsy
Copy link
Member

Mgsy commented Oct 5, 2020

Can you reproduce it also in the pagination demo? I've checked changing font size and it works as expected.

@Mgsy Mgsy added the pending:feedback This issue is blocked by necessary feedback. label Oct 5, 2020
@FilipTokarski
Copy link
Member Author

For me, it still freezes on export-pdf, export-word and pagination demos

@FilipTokarski FilipTokarski removed the pending:feedback This issue is blocked by necessary feedback. label Oct 13, 2020
@mlewand
Copy link
Contributor

mlewand commented Nov 2, 2020

Same for me I can reproduce it on the default content of pagination demo https://ckeditor.com/docs/ckeditor5/23.1.0/features/pagination.html#demo

@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Nov 2, 2020
@mlewand mlewand added this to the backlog milestone Nov 2, 2020
@Reinmar
Copy link
Member

Reinmar commented Nov 23, 2020

image.png

It seems that the post fixers are causing this again. It'd be good to check if this is related to our dear DocumentSelection#markers collection or something else. And if it's something else, whether there's some low-hanging fruit.

@Reinmar
Copy link
Member

Reinmar commented Nov 23, 2020

TODO:

  • Check whether this is triggered by enabling pagination.
  • Check this on latest master as we resolved the markers issue already.
  • Check what's the origin of that (anonymous) that takes 90% of the time. Look for low hanging fruits.

@Reinmar Reinmar modified the milestones: backlog, nice-to-have Nov 23, 2020
@niegowski niegowski modified the milestones: nice-to-have, iteration 39 Dec 4, 2020
@niegowski niegowski self-assigned this Dec 4, 2020
scofalik added a commit that referenced this issue Dec 10, 2020
Other (engine): Improved performance of `Differ#getChanges()`. Closes #8188.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:performance This issue reports a performance issue or a possible performance improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants