Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink dll-sample samples #8675

Closed
jodator opened this issue Dec 15, 2020 · 3 comments · Fixed by #8990
Closed

Rethink dll-sample samples #8675

jodator opened this issue Dec 15, 2020 · 3 comments · Fixed by #8990
Assignees
Labels
domain:extending-builds type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@jodator
Copy link
Contributor

jodator commented Dec 15, 2020

Provide a description of the task

During the work on #8395 we've created a bunch of dll-sample directories to test if the DLL build actually work. However, a better approach might be needed. Those samples were created off the most representative (or random) manual test from the package.

  • A one, mega sample that allows reconfiguring the editor plugins (cc @pomek )
  • Move all dll-sample samples somewhere.
  • What to do with other cases from manual samples?
  • Don't forget about the main dll-sample sample in ckeditor5 repository.
@jodator jodator added type:task This issue reports a chore (non-production change) and other types of "todos". squad:dx domain:extending-builds labels Dec 15, 2020
@jodator jodator added this to the nice-to-have milestone Dec 15, 2020
@AnnaTomanek AnnaTomanek changed the title Rething dll-sample samples Rethink dll-sample samples Dec 28, 2020
@Reinmar
Copy link
Member

Reinmar commented Jan 25, 2021

Some notes:

  • All packages should be available here (all script tags added). We'll have to maintain this file the same way we maintain all-features manual test.
  • Like online builder. We need a list of checkboxes for all plugins. We also need a list of toolbar buttons that they introduce.
    • Idea: we need these metadata anyway. Let's move them from the online builder to each package's package.json.
    • Idea2: The UI part of the online builder was supposed to be made reusable anyway. Let's see if that's doable.
  • When will we need this manual test? During the testing phase and when we'll be working on the DLL support. For the former it's enough to add yarn build:dll to the testing phase steps. For the latter, just mention it in the test description that you need to run this command.

@Reinmar
Copy link
Member

Reinmar commented Jan 25, 2021

In this iteration: Move the current sample to manual tests. We don't want to have this additional directory in the project's root dir.

Let's leave the adhoc plugin (the one that's not being compiled). Consider removing the plugin that needs to be compiled separately. Reasoning: we forget about rebuilding it anyway, plus, it dups what other packages test.

@Reinmar
Copy link
Member

Reinmar commented Jan 25, 2021

The automation and nice UI for the manual test (plugin and toolbar config via clicking) should be exposed to a separate ticket.

@Reinmar Reinmar modified the milestones: nice-to-have, iteration 40 Jan 25, 2021
pomek added a commit that referenced this issue Feb 5, 2021
Internal: Moved the DLL sample to manual test. Closes #8675.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:extending-builds type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants