Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the DLL sample to manual test #8990

Merged
merged 7 commits into from
Feb 5, 2021
Merged

Move the DLL sample to manual test #8990

merged 7 commits into from
Feb 5, 2021

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Feb 4, 2021

Suggested merge commit message (convention)

Internal: Moved the DLL sample to manual test. Closes #8675.

Additional information

  • Added missing re-export TextTransformation in ckeditor5-typing.
  • All plugins from all-features manual test have been used in all-features-dll manual test.
  • The all-features-dll manual test requires DLL build to be run earlier.

pomek
pomek approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as intended.

@pomek pomek merged commit c9c096e into master Feb 5, 2021
@pomek pomek deleted the i/8675 branch February 5, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek pomek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rethink dll-sample samples
2 participants
@psmyrek @pomek