Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor placeholder renders inside page break widget #8880

Closed
niegowski opened this issue Jan 21, 2021 · 5 comments · Fixed by #9060
Closed

Editor placeholder renders inside page break widget #8880

niegowski opened this issue Jan 21, 2021 · 5 comments · Fixed by #9060
Assignees
@pkwasnik
Labels
intro Good first ticket. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Milestone
iteration 40 (v26...

Comments

@niegowski
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. http://fake.ckeditor.com:8125/ckeditor5/tests/manual/all-features.html
  2. remove all content
  3. insert page break

✔️ Expected result

Placeholder is not visible

❌ Actual result

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: current master branch
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@niegowski niegowski added type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases. labels Jan 21, 2021
@oleq
Copy link
Member

oleq commented Jan 21, 2021

Since which version this is a regression?

@niegowski
Copy link
Contributor Author

  • First affected CKEditor version: current master branch

It's caused by the recent changes

@oleq
Copy link
Member

oleq commented Jan 21, 2021 •
edited
Loading

Perhaps we should've used RawElement instead of UIElement in #8858 like here https://github.com/ckeditor/ckeditor5/pull/7621/files#diff-db49af0cd70a2c41fcb5f9489333d6902f44dcbf276d65d4619453525eaacfb7R237.

@Reinmar Reinmar mentioned this issue Jan 22, 2021
Closed
@Reinmar Reinmar added the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Jan 22, 2021
@mlewand mlewand removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Jan 22, 2021
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Jan 25, 2021
@Reinmar Reinmar added this to the nice-to-have milestone Jan 25, 2021
@oleq oleq added the intro Good first ticket. label Jan 25, 2021
@oleq oleq modified the milestones: nice-to-have, iteration 40 Jan 25, 2021
@pkwasnik pkwasnik self-assigned this Feb 18, 2021
@pkwasnik
Copy link
Contributor

@niegowski I can't reproduce it, maybe other changes fixed this. Could you recheck and confirm?

@niegowski
Copy link
Contributor Author

It's still there: (note that the page break must be the only content in the editor)

@pkwasnik pkwasnik mentioned this issue Feb 20, 2021
Merged
mlewand added a commit that referenced this issue Feb 23, 2021
@mlewand
Merge pull request #9060 from ckeditor/i/8880
87ad794 
Internal (page-break): Fixed rendering editor placeholder inside page break widget. Closes #8880.

This is a bug that was only recently introduced on master, not present in any public release so marking as an internal type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
intro Good first ticket. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Milestone
iteration 40 (v26.0.0)
Development

Successfully merging a pull request may close this issue.

Fixed rendering editor placeholder inside page break widget. ckeditor/ckeditor5
5 participants
@Reinmar @oleq @niegowski @mlewand @pkwasnik