Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons are not rounded in the document editor example #912

Closed
Reinmar opened this issue Mar 15, 2018 · 5 comments · Fixed by ckeditor/ckeditor5-editor-decoupled#11
Closed

Buttons are not rounded in the document editor example #912

Reinmar opened this issue Mar 15, 2018 · 5 comments · Fixed by ckeditor/ckeditor5-editor-decoupled#11
Assignees
@oleq
Labels
type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Milestone
iteration 15

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 15, 2018

image

They are fine elsewhere:

image
@Reinmar
Copy link
Member Author

Reinmar commented Mar 15, 2018

BTW, it's the same about the tooltip.

@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide). labels Mar 15, 2018
@Reinmar Reinmar added this to the iteration 15 milestone Mar 15, 2018
@oleq
Copy link
Member

oleq commented Mar 16, 2018

All we need is ck-rounded-corners class added to <div class="document-editor">...</div>.

@Reinmar
Copy link
Member Author

Reinmar commented Mar 16, 2018

That's: ;/

Why doesn't toolbar work out of the box there?

@oleq
Copy link
Member

oleq commented Mar 16, 2018

Because I forgot to add this class when implementing this editor? :P

@Reinmar
Copy link
Member Author

Reinmar commented Mar 16, 2018

OK, from your reply I thought that this is how it's expected to be.

@oleq oleq mentioned this issue Mar 27, 2018
Merged
Reinmar added a commit to ckeditor/ckeditor5-editor-decoupled that referenced this issue Mar 29, 2018
@Reinmar
Merge pull request #11 from ckeditor/t/10
327b2ed 
Other: Allowed the editable element to be passed into `DecoupledEditor.create()`. Removed `config.toolbarContainer` and `config.editableContainer`. Closes #10. Closes ckeditor/ckeditor5#912.

BREAKING CHANGE: The config options `config.toolbarContainer` and `config.editableContainer` have been removed. Please refer to the `DecoupledEditor` class API documentation to learn about possible methods of bootstrapping the UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Milestone
iteration 15
2 participants
@Reinmar @oleq