Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The two-step caret movement requires 3 steps on the left side of a link #946

Closed
jodator opened this issue Apr 6, 2018 · 4 comments · Fixed by ckeditor/ckeditor5-engine#1406
Assignees
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@jodator
Copy link
Contributor

jodator commented Apr 6, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

Latest master (f31e6e1)

📋 Steps to reproduce

  1. I've encountered it in build classic sample.
  2. Navigate through text by cursor towards link (from it's left side so using right arrow).
  3. Place a caret before last character of a word preceding a link.
  4. press right arrow twice (you are "before" link)
  5. press right arrow once (you are still "before" link)
  6. press right arrow again (you are inside a link)

✅ Expected result

you should only need one right arrow press to enter link

❎ Actual result

you need press right arrow twice

📃 Other details that might be useful

screencast 2018-04-06 13_30_52

@jodator
Copy link
Contributor Author

jodator commented Apr 6, 2018

That's weird but the first try (freshly instantiated editor) does not show this error. Only the second and next movements will show this.

@scofalik
Copy link
Contributor

scofalik commented Apr 6, 2018

We know about problems with 2-step-caret-movement. It will be refactored, maybe rewritten. There are more bugs.

@Reinmar Reinmar added this to the backlog milestone Apr 6, 2018
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Apr 6, 2018
@Reinmar Reinmar modified the milestones: backlog, next Apr 6, 2018
@Reinmar Reinmar changed the title The tow-step caret movement requires 3 steps on the left side of a link The two-step caret movement requires 3 steps on the left side of a link Apr 9, 2018
@oleq
Copy link
Member

oleq commented Apr 9, 2018

I'm almost sure this is a DUP of https://github.com/ckeditor/ckeditor5-engine/issues/1301. But let's wait for the research first.

@Reinmar
Copy link
Member

Reinmar commented Apr 9, 2018

We've got so many tickets for two-step caret movement that it'd be good to create an epic for them.

scofalik added a commit to ckeditor/ckeditor5-engine that referenced this issue Apr 18, 2018
Fix: The `bindTwoStepCaretToAttribute` behavioral helper should not fail in more complex cases. Closes #1301. Closes #1346. Closes ckeditor/ckeditor5#937.  Closes ckeditor/ckeditor5#922.  Closes ckeditor/ckeditor5#946.
@Reinmar Reinmar modified the milestones: next, iteration 16 Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
4 participants