Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IME/typing bug-fixing #16289

Merged
merged 36 commits into from
Jul 3, 2024
Merged

IME/typing bug-fixing #16289

merged 36 commits into from
Jul 3, 2024

Commits on Apr 18, 2024

  1. Tracking the composed range so content can be replaced while composing.

    @niegowski
    niegowski committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1e6187d View commit details
    Browse the repository at this point in the history

  2. Added tests.

    @niegowski
    niegowski committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    84e7403 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Added handling of editable focus on beforeinput event.

    @niegowski
    niegowski committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    80f599e View commit details
    Browse the repository at this point in the history

  2. Added tests.

    @niegowski
    niegowski committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b3de933 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Updated code comment.

    @niegowski
    niegowski committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    da0b502 View commit details
    Browse the repository at this point in the history

  2. Updated code comment.

    @niegowski
    niegowski committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d812da8 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #16256 from ckeditor/ck/16106-predictive-text 

    Fix (typing, engine): Predictive text should not get doubled while typing. Closes #16106.
    @niegowski
    niegowski committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    bee09f6 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #16267 from ckeditor/ck/14702 

    Fix (engine): The reverse typing effect should not happen after the focus change. Closes #14702.
    @niegowski
    niegowski committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    5e6c2b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. The MutationObserver should trigger DOM changes only on external chan… 

    …ges, not as a normal flow in IME. Composed text on Android should be inserted to the model only after it is available in the DOM (so on beforeinput is too early). So no mutations other by those made by IME.
    @niegowski
    niegowski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f7ddc79 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'refs/heads/master' into ck/epic/ime-typing

    @niegowski
    niegowski committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4e0b1cb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/ck/epic/ime-typing' into ck/13994-android-re… 

    …verse-typing
    @niegowski
    niegowski committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    eb6e90f View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Queued insertText executions are triggered in a single batch so furth… 

    …er avoiding programmatic DOM changes while composing.
    @niegowski
    niegowski committed May 6, 2024
    Configuration menu
    Copy the full SHA
    22deddf View commit details
    Browse the repository at this point in the history

  2. Added code comments.

    @niegowski
    niegowski committed May 6, 2024
    Configuration menu
    Copy the full SHA
    5cb7e28 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. InsertText queue should adjust command parameters in RTC.

    @niegowski
    niegowski committed May 7, 2024
    Configuration menu
    Copy the full SHA
    98e66ad View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Ignoring NBSP changes while composing. Added trigger to fix post-comp… 

    …osition mutations on composition end.
    @niegowski
    niegowski committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b34ff3d View commit details
    Browse the repository at this point in the history

  2. Debug logs updated.

    @niegowski
    niegowski committed May 8, 2024
    Configuration menu
    Copy the full SHA
    849ec36 View commit details
    Browse the repository at this point in the history

  3. Fixed composition inside a link on desktop.

    @niegowski
    niegowski committed May 8, 2024
    Configuration menu
    Copy the full SHA
    34f8ab0 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Debug logs tuning.

    @niegowski
    niegowski committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d162a70 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Adding tests.

    @niegowski
    niegowski committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7233b08 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Added code comments.

    @niegowski
    niegowski committed May 14, 2024
    Configuration menu
    Copy the full SHA
    08482bb View commit details
    Browse the repository at this point in the history

  2. Code refactoring.

    @niegowski
    niegowski committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b00945c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'refs/heads/master' into ck/epic/ime-typing

    @niegowski
    niegowski committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3945477 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/ck/epic/ime-typing' into ck/13994-android-re… 

    …verse-typing
    @niegowski
    niegowski committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3320fcc View commit details
    Browse the repository at this point in the history

  3. Extracted composition queue to a separate class. Partial verification… 

    … of mutations vs composition elements.
    @niegowski
    niegowski committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9559fa4 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Code refactoring. Proper mutation element search.

    @niegowski
    niegowski committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f2e5b2b View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Post-composition rendering should be triggered after changes made to … 

    …the model to avoid reverting DOM changes and the re-applying them.
    @niegowski
    niegowski committed May 20, 2024
    Configuration menu
    Copy the full SHA
    028d346 View commit details
    Browse the repository at this point in the history

  2. Adding tests.

    @niegowski
    niegowski committed May 20, 2024
    Configuration menu
    Copy the full SHA
    a297c37 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Adding tests.

    @niegowski
    niegowski committed May 21, 2024
    Configuration menu
    Copy the full SHA
    55d6bb5 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Added tests.

    @niegowski
    niegowski committed May 22, 2024
    Configuration menu
    Copy the full SHA
    df6d20c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge branch 'refs/heads/master' into ck/epic/ime-typing

    @niegowski
    niegowski committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ecb5168 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/ck/epic/ime-typing' into ck/13994-android-re… 

    …verse-typing
    @niegowski
    niegowski committed May 24, 2024
    Configuration menu
    Copy the full SHA
    472ad50 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Fixed log message.

    @niegowski
    niegowski committed May 25, 2024
    Configuration menu
    Copy the full SHA
    cf3771c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Review fixes.

    @niegowski
    niegowski committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    4e72e57 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #16300 from ckeditor/ck/13994-android-reverse-typing 

    Fix (engine, typing): Typing on Android should avoid modifying DOM while composing. Closes #13994. Closes #14707. Closes #13850.
    @niegowski
    niegowski committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f610387 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Merge branch 'refs/heads/master' into ck/epic/ime-typing

    @niegowski
    niegowski committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4a1a23b View commit details
    Browse the repository at this point in the history

  2. Added code comments.

    @niegowski
    niegowski committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ce023f1 View commit details
    Browse the repository at this point in the history