Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I/7559: Update ImageResizeUI plugin #7616

Merged
merged 27 commits into from
Jul 17, 2020
Merged

I/7559: Update ImageResizeUI plugin #7616

merged 27 commits into from
Jul 17, 2020

Conversation

panr
Copy link
Contributor

@panr panr commented Jul 13, 2020

Suggested merge commit message (convention)

Other (image): Improved ImageResizeUI plugin UI. Added the dedicated icons for each option (small, medium, large and original) and the dropdown (dropdown icon). Closes #7559.

Other (image): Improved screen reader experience for ImageResizeUI standalone buttons in the image.toolbar.

Other (core): Added icons that represent the size of the element (object-size-*).

@oleq oleq self-requested a review July 14, 2020 09:34
@oleq oleq self-assigned this Jul 14, 2020
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we have something like this to save space in the toolbar?

.ck.ck-dropdown .ck-button.ck-resize-image-button .ck-button__label {
    width: 4em;
}

packages/ckeditor5-image/src/imageresize/imageresizeui.js Outdated Show resolved Hide resolved
packages/ckeditor5-image/src/imageresize/imageresizeui.js Outdated Show resolved Hide resolved
packages/ckeditor5-image/src/imageresize/imageresizeui.js Outdated Show resolved Hide resolved
packages/ckeditor5-image/src/imageresize/imageresizeui.js Outdated Show resolved Hide resolved
packages/ckeditor5-image/src/imageresize/imageresizeui.js Outdated Show resolved Hide resolved
packages/ckeditor5-image/src/imageresize/imageresizeui.js Outdated Show resolved Hide resolved
packages/ckeditor5-image/src/imageresize/imageresizeui.js Outdated Show resolved Hide resolved
packages/ckeditor5-image/src/imageresize/imageresizeui.js Outdated Show resolved Hide resolved
packages/ckeditor5-image/theme/imageresize.css Outdated Show resolved Hide resolved
@panr
Copy link
Contributor Author

panr commented Jul 16, 2020

Phew... I fixed them all 😅

@panr panr requested a review from oleq July 16, 2020 08:01
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved some docs and refactored the code a little bit. Still:

@oleq
Copy link
Member

oleq commented Jul 16, 2020

@ckeditor/qa-team Can you take a look at this PR? Thanks 🙏

@panr
Copy link
Contributor Author

panr commented Jul 16, 2020

Localization entries are missing.
Missing changelog entry for ckeditor5-core.
Docs are bleeding (CKEditorError: imageresizeui-missing-icon)
http://fake.ckeditor.com/ck/5/ckeditor5/build/docs/ckeditor5/latest/features/image.html#resizing-images.

Fixed it.

@panr panr requested a review from oleq July 16, 2020 13:06
@FilipTokarski
Copy link
Member

FilipTokarski commented Jul 16, 2020

I reported a bug with jumping blue border, which occurs also on master ( and since a long time ), but it gets much more visible when using those new buttons for resizing.

Original issue: #7633

Screencast:

16_image_5

@FilipTokarski
Copy link
Member

Apart from what I mentioned above, everything seems to be ok 👍

@oleq oleq merged commit 565628a into master Jul 17, 2020
@oleq oleq deleted the i/7559 branch July 17, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon for ImageResizeUI plugin
3 participants