Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting of custom errors. #8218

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Update formatting of custom errors. #8218

merged 3 commits into from
Oct 14, 2020

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Oct 6, 2020

Suggested merge commit message (convention)

Other (utils): Make custom errors more readable in the console. Closes #8140.

MINOR BREAKING CHANGE (utils): The attachLinkToDocumentiation() helper was removed. To log errors to the console with attached link to a documentation use logWarning() or logError().


Additional information

  • Implementation is based on this comment.
  • instead of attachLinkToDocumentation() I've created logWarning and logError helper methods. The logError is used only once in the editor. This was needed to properly order optional data objects when logging (see tests)
  • No other CKSource projects are using attachLinkToDocumentation() AFAICS

@Reinmar
Copy link
Member

Reinmar commented Oct 14, 2020

❤️

@Reinmar Reinmar merged commit 40801ba into master Oct 14, 2020
@Reinmar Reinmar deleted the i/8140 branch October 14, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better formatting of custom errors
2 participants