Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLL build proposal #8564

Merged
merged 50 commits into from
Dec 4, 2020
Merged

DLL build proposal #8564

merged 50 commits into from
Dec 4, 2020

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Dec 2, 2020

Suggested merge commit message (convention)

Feature: Introduce the CKEditor 5 DLL build. Closes #8517.


Additional information

WIP for now.

jodator and others added 30 commits November 4, 2020 14:20
@jodator jodator changed the base branch from master to dll-integration December 3, 2020 13:05
@jodator
Copy link
Contributor Author

jodator commented Dec 3, 2020

Things to open this PR to review:

@jodator jodator requested a review from pomek December 3, 2020 13:29
@pomek
Copy link
Member

pomek commented Dec 4, 2020

I don't want to be the person who will update 50 different webpack.config.js files if something should be changed :D

Let's extract the common part to a factory function (https://github.com/ckeditor/ckeditor5-dev/blob/i/8521/packages/ckeditor5-dev-utils/lib/builds/getpluginwebpackconfig.js) and modify the output via options (https://github.com/ckeditor/ckeditor5/blob/i/8521/packages/ckeditor5-html-embed/webpack.config.js).

@jodator
Copy link
Contributor Author

jodator commented Dec 4, 2020

@pomek that's a sound idea :) Let's have done during review. For now I'm trying to get green CI to have a starting point.

@jodator
Copy link
Contributor Author

jodator commented Dec 4, 2020

I'm waiting for the CI to validate that everything runs smoothly. The last piece is to add a build script for all the DLLs. I would push it now, but Travis still builds... 🤷‍♂️

@jodator
Copy link
Contributor Author

jodator commented Dec 4, 2020

🟢 🎉

@jodator jodator merged commit 577add9 into dll-integration Dec 4, 2020
@jodator jodator deleted the i/8517 branch December 4, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DLLs for CKEditor 5 features
2 participants