Refactor modeler control flow handling into methods. #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mstarzinger Thanks a lot! Could you please resolve the conflicts? I had to commit my changes first to make sure yours will work too. |
This just refactors the handling of in-edges in modelers control flow chaining into separate methods. It is intended to make the while-loop iterating over all program locations smaller, because its size exceeded one of the limits built into selfie under certain circumstances. No functional changes intended. See issue cksystemsteaching#303 for more details. Kudos to @mhatzl for spotting and debugging this.
mstarzinger
force-pushed
the
refactor-modeler-control-flow
branch
from
528c8da
to
9e914ba
Compare
|
@ckirsch Sure thing. I rebased and resolved conflicts. |
ckirsch
added a commit
that referenced
this pull request
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just refactors the handling of in-edges in modelers control flow
chaining into separate methods. It is intended to make the while-loop
iterating over all program locations smaller, because its size exceeded
one of the limits built into selfie under certain circumstances. No
functional changes intended. See issue #303 for more details.
Kudos to @mhatzl for spotting and debugging this.