-
Notifications
You must be signed in to change notification settings - Fork 6
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wishlist] please use more contrast button icon #8
Comments
That's a good idea! I will definitely look into doing that when I have some time. Or if you're up to the challenge, you could try creating it yourself? |
Do you have a vectorized image for the icon? I see only raster/png version in the repo. |
The original image is from ionicons. The X I just pasted on top in like GIMP I think, so there's no vector at all of that (sorry!). |
BTW, it might be better to have an svg source in the tree and generate pngs in runtime. However, it will create a build dependency on something like imagemagick. |
I'm okay just including the svg - it's no big deal to add depends for development in my opinion. |
OK, so I'll prepare a patch with all png images removed and added svg with some makefile rules to generate png. |
Have some patch, want to verify but can't (re)install the addon from make-generated zip. Tried install from file at FF addons page, but it tells the file is corrupted. |
If you go to |
Yes, it helps, thanks a lot! |
MDN says that you can give any number of icons, and recommends providing a 48x48 px icon as a default. I'll leave it to your discretion how many and what sizes should be chosen 👍 |
GitHub issue ckuhl#8: "[wishlist] please use more contrast button icon" Current icons are black and hardly visible on dark FF themes. Use modified SVG source with light outline for better visibility. Remove PNG files from repo and generate them in makefile. Add 16x16 and 24x24 png size as well. SVG taken from Ionicons iconset (http://ionicons.com/) and are used here under the MIT license: http://opensource.org/licenses/MIT
OK, I just add 16x16 and 24x24 and let FF decide. |
GitHub issue ckuhl#8: "[wishlist] please use more contrast button icon" Current icons are black and hardly visible on dark FF themes. Use modified SVG source with light outline for better visibility. Remove PNG files from repo and generate them in makefile. Add 16x16 and 24x24 png size as well. SVG taken from Ionicons iconset (http://ionicons.com/) and are used here under the MIT license: http://opensource.org/licenses/MIT
Current button image is dark and is hardly recognized with dark FF themes.
Any universal style would be better (just white outline might be enough).
The text was updated successfully, but these errors were encountered: