fix the return type of multiply_image_and_position() #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for images of type int8, multiply_image_and_position was limited to positions < 256 (and for int16 to positions < 2^16), because the return type was the same as the image type. However int8 images can have positions larger than that because position indices are of type int32. This commit ensures that the return type is at least int32 so that multiply_image_and_position can handle positions larger than the maximum integer for int8 and int16 images. closes issue tier1::multiply_image_and_position_func() implicitly assumes that the position has the same type as the input. #287
StRigaud
reviewed
Apr 29, 2024
|
I don't know why the tests are failing as it does not look like your PR touched anything that could break them... |
that way, the output type is well defined and we do not risk rounding errors in functions that have floating point input, such as center_of_mass()
|
Its good to merge with the exception that the CI/CD for the tests and coverage is dead. |
StRigaud
approved these changes
May 1, 2024
we now rely on multiply_image_and_position() to return FLOAT values
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 55.60% 55.61% +0.01%
==========================================
Files 232 232
Lines 3705 3704 -1
Branches 1473 1472 -1
==========================================
Hits 2060 2060
Misses 493 493
+ Partials 1152 1151 -1 ☔ View full report in Codecov by Sentry. |
|
This can be merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for images of type int8, multiply_image_and_position was limited to positions < 256 (and for int16 to positions < 2^16), because the return type was the same as the image type. However int8 images can have positions larger than that because position indices are of type int32. This pull request ensures that the return type is at least int32 so that multiply_image_and_position can handle positions larger than the maximum integer for int8 and int16 images.
closes issue tier1::multiply_image_and_position_func() implicitly assumes that the position has the same type as the input. #287