Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add largePositionInt8 unit test for bounding_box #291

Merged
merged 3 commits into from
May 3, 2024

Conversation

thawn
Copy link
Collaborator

@thawn thawn commented May 2, 2024

this unit test tests whether bounding_box can return positions larger than the maximum value of the input image. (e.g. larger than 255 for int8). Prevent regression of bug clEsperanto/pyclesperanto#164

this unit test tests whether bounding_box can return positions larger than the maximum value of the input image. (e.g. larger than 255 for int8). Prevent regression of bug clEsperanto/pyclesperanto#164
Copy link
Collaborator Author

@thawn thawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this unit test will fail until pull request #288 is merged.

@StRigaud
Copy link
Member

StRigaud commented May 3, 2024

Merging,
Thanks @thawn !

@StRigaud StRigaud merged commit 414f193 into master May 3, 2024
5 checks passed
@StRigaud StRigaud deleted the test-bounding-box-large-position branch June 25, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants