Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiply image and positions #294

Merged
merged 5 commits into from
May 3, 2024
Merged

Commits on Apr 28, 2024

  1. fix the return type of multiply_image_and_position

    for images of type int8, multiply_image_and_position was limited to positions < 256 (and for int16 to positions < 2^16), because the return type was the same as the image type. However int8 images can have positions larger than that because position indices are of type int32. This commit ensures that the return type is at least int32 so that multiply_image_and_position can handle positions larger than the maximum integer for int8 and int16 images.
    
    closes issue tier1::multiply_image_and_position_func() implicitly assumes that the position has the same type as the input. #287
    thawn committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    3c0de89 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. always return FLOAT

    that way, the output type is well defined and we do not risk rounding errors in functions that have floating point input, such as center_of_mass()
    thawn committed May 1, 2024
    Configuration menu
    Copy the full SHA
    bec46a4 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. revert bounding box type fix

    we now rely on multiply_image_and_position() to return FLOAT values
    thawn committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c799a29 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #293 from clEsperanto/master

    fix CI
    StRigaud committed May 2, 2024
    Configuration menu
    Copy the full SHA
    fb25f14 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Merge pull request #288 from clEsperanto/fix_multiply_image_and_posit…

    …ion_return_type
    
    fix the return type of multiply_image_and_position()
    thawn committed May 3, 2024
    Configuration menu
    Copy the full SHA
    384f6c0 View commit details
    Browse the repository at this point in the history