Merge pull request #408 from jsoref/issue-349

improve handling of noscript (related to #349)
cla-assistant · Feb 6, 2019 · acab844 · acab844
2 parents 64edc29 + 9780f27
commit acab844
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/src/client/app.js b/src/client/app.js
@@ -17,6 +17,7 @@ var filters = angular.module('cla.filters', []);
 
 angular.element(document).ready(function () {
     angular.bootstrap(document, ['app']);
+    angular.element(document.querySelectorAll('.needs-javascript')).removeClass('needs-javascript');
 });
 
 // *************************************************************

diff --git a/src/client/assets/styles/app.scss b/src/client/assets/styles/app.scss
@@ -598,3 +598,7 @@ a.anchor .octicon-link {
   font-size: smaller;
   display: inline-block;
 }
+
+.needs-javascript {
+  display: none;
+}
diff --git a/src/client/home.html b/src/client/home.html
@@ -44,9 +44,11 @@
             <div class="navbar-home-left">
                 <div ng-show="!!user.value.login">
                     <a ng-href="{{user.value.html_url}}" target="spcae">
-                        <img ng-src="{{ user.value.avatarUrl }}" style="height:25px;" />
+                        <img class="needs-javascript" alt="[ {{ user.value.login }} avatar ]" ng-src="{{ user.value.avatarUrl }}" style="height:25px;" />
                         <a class="navbar-text-hide">&nbsp; Hey,
-                            <b>{{ user.value.login }}</b>!</a>
+                            <noscript>GitHub user whose browser isn't processing JavaScript</noscript>
+                            <b class="needs-javascript">{{ user.value.login }}</b>!
+                        </a>
                     </a>
                 </div>
             </div>
@@ -56,7 +58,7 @@
             </div>
             <div class="navbar-center">
                 <a href="/">
-                    <img class="center-block img-responsive" src="/assets/images/logo_b.svg" style="width:55px;">
+                    <img class="center-block img-responsive" src="/assets/images/logo_b.svg" alt="[ CLA - assistant ]" style="width:55px;">
                 </a>
             </div>
         </div>
@@ -99,4 +101,4 @@
     </div>
 </body>
 
-</html>
+</html>