-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve handling of noscript (related to #349) #408
Conversation
As an aside, when I do enable JS, I get:
for
Which results in the Hey message disappearing:
|
Thank you very much for looking into it, appreciate your work! But this wouldn't solve the general problem that the whole application is written in JS and wouldn't work in 'no JS'-mode anyway. |
@KharitonOff : the message can be adjusted... |
Ok, I see. If we make it clear in a |
If you want to write that text, I can integrate it, or you can merge this and work from it. |
improve handling of noscript (related to #349)
This is a rough attempt at improving the behavior of cla-assistant as seen by browsers that render
<noscript>
Currently the rendering looks like this:
![image](https://user-images.githubusercontent.com/2119212/51889732-4bfdb580-2368-11e9-9549-b334a935171f.png)
(That the username disappears long before the brand logo is a little odd, but we can cross the mobile bridge later.)