Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribute to upstream #435

Merged
merged 14 commits into from
May 21, 2019
Merged

Contribute to upstream #435

merged 14 commits into from
May 21, 2019

Conversation

MichaelTsengLZ
Copy link
Contributor

@MichaelTsengLZ MichaelTsengLZ commented Apr 24, 2019 •
edited
Loading

Bugfixes:

  1. Whitelist should use exact match when there is no wildcard (*). We don't want to pass a foo-like-user when we white list foo.
  2. When updating a linked repo, we should validate input. And should allow whiteListPattern and privacyPolicy as empty string.
  3. Fix small issues when updating org/repo in UI.
  4. Do not get pull request files to check significant changes, there is enough information in the pull request itself. In this way, we could avoid the Github abuse exception when there are thousands of commits in a pull request.

Security:

  1. Setup cookie secure

New feature:

  1. Add readiness route so that Kubernetes could better swap pods.
  2. Show CLA updated date in the CLA signing page.

Refactor:
The refactor is mainly about placing callbacks with promises. It helps to clean the code and easily add key metrics.

@coveralls
Copy link

coveralls commented Apr 24, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 90.351% when pulling e67e2d2 on microsoft:miczeng/contributeToUpStream into c6a02bc on cla-assistant:master.

@MichaelTsengLZ MichaelTsengLZ force-pushed the miczeng/contributeToUpStream branch 3 times, most recently from f722a78 to 060a03f Compare April 25, 2019 19:48
@MichaelTsengLZ
Set cookie secure attribute to true.
b0b36b8
@MichaelTsengLZ
Trust proxy
c3938f0
@MichaelTsengLZ
Feature: Add CLA updated date as version.
b2faffc 
* Add CLA updated date as version.

* Nitfix: CLA signing page headline should show shared gist information.
@MichaelTsengLZ
Bugfix: big pull request abuse github api rate limits
ec7497d 
When pull request is really big, like thousands of commits, getPullRequestFiles will try to get all commits.
These will abuse github api. Use getPR() api instead.
@MichaelTsengLZ
Bugfix: link org/repo and update org/repo issues
e5ba27b 
1. Should be able to link null gist cla
2. Update linked item should not delete the gist info
@MichaelTsengLZ
Bugfix: Should not throw error when org is not found in database
2c4662e 
Add test for api/org
@MichaelTsengLZ
Bugfix: Should not swallow the exception
7acf7ad
@MichaelTsengLZ
Bugfix: when update linked repo/org, validate input correctly
ff8414a 
1. Should allow the value of whiteListPattern and privacyPolicy to be empty string when they were cleaned up in UI.
2. Should validate repo input when updating linked repo.
3. Add test for api/repo
@MichaelTsengLZ
Bugfix: White list users should use exact match.
fbffd74 
For example, we don't want user named 'Intel-like' pass our CCLA when 'Intel' is in the whitelist.
@MichaelTsengLZ
Feature: Add readiness route so that Kubernetes could better swap pods
ac54e6a
@MichaelTsengLZ
Add more test to improve test coverage
dc640d0
@MichaelTsengLZ
Bugfix: user_map.includes is not a function
42d932f
KharitonOff
KharitonOff suggested changes May 16, 2019
View reviewed changes
src/server/api/org.js Outdated Show resolved Hide resolved
src/server/documents/utils.js Show resolved Hide resolved
@KharitonOff KharitonOff merged commit 1711c2a into cla-assistant:master May 21, 2019
@KharitonOff
Copy link
Contributor

Thank you!

KharitonOff added a commit that referenced this pull request Feb 18, 2020
@KharitonOff
Merge pull request #435 from microsoft/miczeng/contributeToUpStream
7c4c75d 
Contribute to upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KharitonOff KharitonOff KharitonOff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelTsengLZ @coveralls @KharitonOff