-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribute to upstream #435
Merged
KharitonOff
merged 14 commits into
cla-assistant:master
from
microsoft:miczeng/contributeToUpStream
May 21, 2019
Merged
Contribute to upstream #435
KharitonOff
merged 14 commits into
cla-assistant:master
from
microsoft:miczeng/contributeToUpStream
May 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f722a78
to
060a03f
Compare
* Add CLA updated date as version. * Nitfix: CLA signing page headline should show shared gist information.
When pull request is really big, like thousands of commits, getPullRequestFiles will try to get all commits. These will abuse github api. Use getPR() api instead.
1. Should be able to link null gist cla 2. Update linked item should not delete the gist info
Add test for api/org
1. Should allow the value of whiteListPattern and privacyPolicy to be empty string when they were cleaned up in UI. 2. Should validate repo input when updating linked repo. 3. Add test for api/repo
For example, we don't want user named 'Intel-like' pass our CCLA when 'Intel' is in the whitelist.
060a03f
to
42d932f
Compare
KharitonOff
suggested changes
May 16, 2019
KharitonOff
approved these changes
May 21, 2019
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes:
foo-like-user
when we white listfoo
.whiteListPattern
andprivacyPolicy
as empty string.Security:
New feature:
Refactor:
The refactor is mainly about placing callbacks with promises. It helps to clean the code and easily add key metrics.