Matmul code and speed improvements #1483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #1355 and rewrite the matmul and affinetransform nodes to reduce code duplication (now all the matmul/matmul+transpose logic lives in
matrix-multiply.h
only).This should also enable cublas batched matmul in the backward pass, which hopefully will make things like dot attention faster.
TODO:
matrix-multiply.h
(cf Added batched matrix multiplies on CUDA #1355)[ ] Add matmul + transpose as an operation (add the option to transpose in the matmul node)<- maybe for a future PR but this should help further with attention (both memory and speed wise)