-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Trainer::update_epoch #852
Conversation
It was deprecated in clab#695.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you completely remove the first variable from these examples? Then I'll be happy to merge.
@@ -156,7 +156,7 @@ int main(int argc, char** argv) { | |||
for (unsigned i = 0; i < report_every_i; ++i) { | |||
if (si == training.size()) { | |||
si = 0; | |||
if (first) { first = false; } else { sgd->update_epoch(); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great. We can also probably remove the "first" variable entirely, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Please take a look.
Thanks! |
Additional fix for clab#852.
This PR removes the deprecated method call used in the examples.
The method was deprecated in #695.
This change is