SystemHeadersMapping doesn't work in dynamic index #8
Assignees
Comments
|
Fixed with https://reviews.llvm.org/D58029 |
llvm-git-migration
pushed a commit
to llvm/llvm-project
that referenced
this issue
Feb 11, 2019
…back Summary: SystemHeaderMappings were added only after takeIncludes call, which resulted in getting mapping on main file ast updates but not on preamble ast updates. Fixes clangd/clangd#8 Reviewers: hokein Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D58029 llvm-svn: 353687
dtzWill
pushed a commit
to llvm-mirror/clang-tools-extra
that referenced
this issue
Feb 11, 2019
…back Summary: SystemHeaderMappings were added only after takeIncludes call, which resulted in getting mapping on main file ast updates but not on preamble ast updates. Fixes clangd/clangd#8 Reviewers: hokein Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D58029 git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@353687 91177308-0d34-0410-b5e6-96231b3b80d8
jrtc27
pushed a commit
to CTSRD-CHERI/llvm-project
that referenced
this issue
Feb 22, 2019
…back Summary: SystemHeaderMappings were added only after takeIncludes call, which resulted in getting mapping on main file ast updates but not on preamble ast updates. Fixes clangd/clangd#8 Reviewers: hokein Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D58029 llvm-svn: 353687
shrouxm
pushed a commit
to sourcegraph/lsif-clang
that referenced
this issue
Jul 12, 2020
…back Summary: SystemHeaderMappings were added only after takeIncludes call, which resulted in getting mapping on main file ast updates but not on preamble ast updates. Fixes clangd/clangd#8 Reviewers: hokein Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D58029 llvm-svn: 353687
Closed
Closed
This was referenced Apr 27, 2022
This was referenced Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In https://reviews.llvm.org/D57508, we enable include insertion in dynamic index.
Reproduce step:
Actual result:
Expected result: The include header should be STL header, e.g.
<memory>.Off-topic: this feature seems a bit noisy, in the sample above, completion symbols are from
<vector>or headers being included transitively, the code is still compilable without the include insertion.The text was updated successfully, but these errors were encountered: