Update decoration type for inactive-regions when settings change #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HighCommander4
requested changes
Apr 7, 2024
HighCommander4
approved these changes
Apr 7, 2024
HighCommander4
requested changes
Apr 7, 2024
There was a problem hiding this comment.
Whoops, I forgot that the CI only runs if I press the 'Approve' button for it.
Could you format the patch so it passes the clang-format check please? You can see the details of the failure at https://github.com/clangd/vscode-clangd/actions/runs/8586071839/job/23528283548?pr=613.
HighCommander4
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, when changing the 'inactive-regions' settings, users need to restart VSCode for the changes to take effect. This PR makes the extension automatically applies these effects upon detecting user modifications to the settings, enhancing user experience.