Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 master #1988

Closed
wants to merge 2 commits into from
Closed

V2 master #1988

wants to merge 2 commits into from

Conversation

U007D
Copy link

@U007D U007D commented Jun 26, 2020

Fix deprecated warning during build

@U007D
Copy link
Author

U007D commented Jun 26, 2020

fixes

warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred
  --> alacritty/src/cli.rs:71:21
   |
71 |             .author(crate_authors!("\n"))
   |                     ^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default
   = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

when building dependent crate

@CreepySkeleton
Copy link
Contributor

MSRV for 2.x branch is 1.24, but this change would bump it to 1.32. I think you're going to have to live with it. Strategically placed #[allow(deprecated)] might help.

@U007D
Copy link
Author

U007D commented Jun 26, 2020

Ah, thanks--good to know.

@jhpratt
Copy link

jhpratt commented Aug 12, 2020

@CreepySkeleton Would a PR with #[allow(deprecated)] on the macro-generated code be accepted? It's quite annoying to have a deprecation warning on every build.

@pksunkara
Copy link
Member

@jhpratt Go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants