Ignore deprecation warning in clap macro invocation #1910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe about time to get rid of the annoying:
I have realized that
clap
will never fix the warning. Simply because that would bump the MSRV, andclap 2
has apparently stated that it should remain at 1.24 🤷♂️ :( (clap-rs/clap#1988)So I rearranged the code a little bit in order to be able to stick an
#[allow(deprecated)]
on the problematic code, but just as little of it as possible.We use the same macro in
mullvad-cli
. But for some reason that does not emit any warning during regular build, so I did not touch it. I don't know why and I did not spend any time on figuring it out either.Git checklist:
CHANGELOG.md
under the[Unreleased]
header.This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)