Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not always print version information to stdout #2007

Closed
wants to merge 1 commit into from

Conversation

davidMcneil
Copy link
Contributor

Signed-off-by: David McNeil mcneil.david2@gmail.com

Closes #2006

Signed-off-by: David McNeil <mcneil.david2@gmail.com>
@pksunkara
Copy link
Member

We are not accepting any non-security PRs to v2 branch. This has been fixed in v3 master.

@CreepySkeleton
Copy link
Contributor

I agree with @pksunkara, v2 is frozen.

Come to think of it, the ErrorKind in question is VersionDisplayed, past tense. I think it was intentional.

We need to rename it to DisplayVersion in 3.0 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants