Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mut_subcommand method to modify existing subcommands #3882

Merged
merged 1 commit into from Jun 30, 2022

Conversation

emersonford
Copy link
Contributor

@emersonford emersonford commented Jun 28, 2022

implements #3881

@emersonford emersonford force-pushed the mut_subcommands branch 2 times, most recently from 2960976 to d509c11 Compare Jun 29, 2022
src/builder/command.rs Outdated Show resolved Hide resolved
this allows us modify existing subcommands on an existing/already built
Command struct
@epage epage merged commit 5ca73f3 into clap-rs:master Jun 30, 2022
20 checks passed
@epage
Copy link
Member

epage commented Jun 30, 2022

v3.2.8 is now released with this

facebook-github-bot pushed a commit to facebookexperimental/eden that referenced this issue Jul 6, 2022
Summary:
v3.2.8 incorporates clap-rs/clap#3882, which is needed for some of the Clap w/ Python CLI fallback code I'm working on.

Ran all of the steps in https://www.internalfb.com/intern/wiki/Rust-at-facebook/Managing_fbsource_third-party_with_Reindeer/#overview

Reviewed By: zertosh

Differential Revision: D37566754

fbshipit-source-id: 998a4cd79c660d34c5e8468b2b27b6e0971f80ef
facebook-github-bot pushed a commit to facebook/hhvm that referenced this issue Jul 6, 2022
Summary:
v3.2.8 incorporates clap-rs/clap#3882, which is needed for some of the Clap w/ Python CLI fallback code I'm working on.

Ran all of the steps in https://www.internalfb.com/intern/wiki/Rust-at-facebook/Managing_fbsource_third-party_with_Reindeer/#overview

Reviewed By: zertosh

Differential Revision: D37566754

fbshipit-source-id: 998a4cd79c660d34c5e8468b2b27b6e0971f80ef
facebook-github-bot pushed a commit to facebookincubator/below that referenced this issue Jul 6, 2022
Summary:
v3.2.8 incorporates clap-rs/clap#3882, which is needed for some of the Clap w/ Python CLI fallback code I'm working on.

Ran all of the steps in https://www.internalfb.com/intern/wiki/Rust-at-facebook/Managing_fbsource_third-party_with_Reindeer/#overview

Reviewed By: zertosh

Differential Revision: D37566754

fbshipit-source-id: 998a4cd79c660d34c5e8468b2b27b6e0971f80ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants