Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AZ-434 Add function errors instrumentation detector #246

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

jmapro
Copy link
Contributor

@jmapro jmapro commented Feb 17, 2021

Add a detector for specific metrics generated by the signalfx languages wrapper (C#, Java, NodeJs, Python)

Copy link
Contributor

@xp-1000 xp-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks

just some minor comments and suggestions

modules/integration_azure-functions/README.md Outdated Show resolved Hide resolved
modules/integration_azure-functions/conf/readme.yaml Outdated Show resolved Hide resolved
@jmapro jmapro force-pushed the AZ-434-azure-function-detectors branch from bb7ff42 to 3d9a55d Compare February 18, 2021 07:53
@jmapro jmapro force-pushed the AZ-434-azure-function-detectors branch from 3d9a55d to e0acf5a Compare February 18, 2021 08:18
@jmapro jmapro mentioned this pull request Feb 18, 2021
Copy link
Contributor

@xp-1000 xp-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to merge #248 first

@jmapro jmapro force-pushed the AZ-434-azure-function-detectors branch from bd88a41 to 000df43 Compare February 22, 2021 13:14
@jmapro jmapro force-pushed the AZ-434-azure-function-detectors branch from 000df43 to 47cb0e1 Compare February 22, 2021 13:20
@xp-1000 xp-1000 requested a review from BzSpi February 22, 2021 17:42
@xp-1000 xp-1000 merged commit 61a0ded into master Feb 22, 2021
@xp-1000 xp-1000 deleted the AZ-434-azure-function-detectors branch February 22, 2021 17:43
@xp-1000 xp-1000 self-assigned this Feb 22, 2021
@xp-1000 xp-1000 added detectors About nex or existing detectors new feature Request for new feature labels Feb 22, 2021
@xp-1000 xp-1000 added this to In progress in Claranet via automation Feb 22, 2021
@xp-1000 xp-1000 added this to the v1.2.0 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detectors About nex or existing detectors new feature Request for new feature
Projects
Claranet
In progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants