-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AZ-434 Add function errors instrumentation detector #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmapro
requested review from
BzSpi,
cvauvarin,
Shr3ps and
xp-1000
as code owners
February 17, 2021 17:13
xp-1000
suggested changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks
just some minor comments and suggestions
modules/integration_azure-functions/conf/01-function-errors.yaml
Outdated
Show resolved
Hide resolved
modules/integration_azure-functions/conf/01-function-errors.yaml
Outdated
Show resolved
Hide resolved
jmapro
force-pushed
the
AZ-434-azure-function-detectors
branch
from
February 18, 2021 07:53
bb7ff42
to
3d9a55d
Compare
BzSpi
previously requested changes
Feb 18, 2021
xp-1000
suggested changes
Feb 18, 2021
jmapro
force-pushed
the
AZ-434-azure-function-detectors
branch
from
February 18, 2021 08:18
3d9a55d
to
e0acf5a
Compare
Merged
xp-1000
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we need to merge #248 first
modules/integration_azure-functions/conf/01-function-errors.yaml
Outdated
Show resolved
Hide resolved
modules/integration_azure-functions/conf/01-function-errors.yaml
Outdated
Show resolved
Hide resolved
Shr3ps
approved these changes
Feb 18, 2021
jmapro
force-pushed
the
AZ-434-azure-function-detectors
branch
from
February 22, 2021 13:14
bd88a41
to
000df43
Compare
jmapro
force-pushed
the
AZ-434-azure-function-detectors
branch
from
February 22, 2021 13:20
000df43
to
47cb0e1
Compare
xp-1000
added
detectors
About nex or existing detectors
new feature
Request for new feature
labels
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a detector for specific metrics generated by the signalfx languages wrapper (C#, Java, NodeJs, Python)