Feature/lasting #248
Merged
Feature/lasting #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmapro
requested review from
BzSpi,
cvauvarin,
Shr3ps and
xp-1000
as code owners
jmapro
force-pushed
the
feature/lasting
branch
from
ba0dd99
to
6e3ce3e
Compare
xp-1000
suggested changes
Feb 18, 2021
jmapro
force-pushed
the
feature/lasting
branch
from
472b2ce
to
9588fb1
Compare
jmapro
force-pushed
the
feature/lasting
branch
from
9588fb1
to
e8d753d
Compare
xp-1000
suggested changes
Feb 22, 2021
There was a problem hiding this comment.
seems good for me, please you have to add this new parameter in https://github.com/claranet/terraform-signalfx-detectors/blob/master/scripts/templates/values.yaml file for documentation purpose
jmapro
force-pushed
the
feature/lasting
branch
2 times, most recently
from
e980337
to
94287b4
Compare
jmapro
force-pushed
the
feature/lasting
branch
from
94287b4
to
1573b42
Compare
xp-1000
suggested changes
Feb 22, 2021
jmapro
force-pushed
the
feature/lasting
branch
from
811fd22
to
fee6735
Compare
xp-1000
suggested changes
Feb 22, 2021
jmapro
force-pushed
the
feature/lasting
branch
from
fee6735
to
4efe269
Compare
xp-1000
added
new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #247
Needed for #246