-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit-autoupdate #338
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage 92.95% 92.95%
=======================================
Files 40 40
Lines 3778 3778
=======================================
Hits 3512 3512
Misses 266 266 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 🤖
9f5b954
to
18bfd81
Compare
18bfd81
to
163241c
Compare
09666da
to
5304bd8
Compare
5304bd8
to
d4d6e20
Compare
Why have these tests failed? This was just an update to various pre-commit hooks. |
updates: - [github.com/asottile/pyupgrade: v3.9.0 → v3.10.1](asottile/pyupgrade@v3.9.0...v3.10.1) - [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1) - [github.com/DavidAnson/markdownlint-cli2: v0.8.1 → v0.9.2](DavidAnson/markdownlint-cli2@v0.8.1...v0.9.2) - [github.com/pycqa/flake8.git: 6.0.0 → 6.1.0](https://github.com/pycqa/flake8.git/compare/6.0.0...6.1.0) - [github.com/pre-commit/mirrors-mypy: v1.4.1 → v1.5.1](pre-commit/mirrors-mypy@v1.4.1...v1.5.1) - [github.com/astral-sh/ruff-pre-commit: v0.0.280 → v0.0.288](astral-sh/ruff-pre-commit@v0.0.280...v0.0.288) - [github.com/pycqa/pylint: v3.0.0a6 → v3.0.0a7](pylint-dev/pylint@v3.0.0a6...v3.0.0a7)
d4d6e20
to
dd8aa75
Compare
I checked the error for my PR and is because this message
Do i changed a |
Thanks. That makes sense. So basically the flake8 update has introduced
some new checks. I’ll fix this and do the merge.
…On Wed, 13 Sep 2023 at 19:46, Gerardo Roa Dabike ***@***.***> wrote:
Why have these tests failed? This was just an update to various pre-commit
hooks.
I checked the error for my PR and is because this message
notebooks/03_Running_the_CEC2_baseline_from_python.ipynb:cell_4:4:8: E721
do not compare types, for exact checks use > is / is not, for instance
checks use isinstance()
Do i changed a type(cfg) == Docstring to isinstance(cfg, Docstring)
fixing the error
—
Reply to this email directly, view it on GitHub
<#338 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACO7SJA6CBPSL3W2NHQXVBLX2H5RNANCNFSM6AAAAAA27TPL7E>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Signed-off-by: Gerardo Roa Dabike <gerardo.roa@gmail.com>
I did the fix and pushed it. |
Thanks for that.
On Thu, 14 Sept 2023 at 20:03, Gerardo Roa Dabike ***@***.***>
wrote:
… Thanks. That makes sense. So basically the flake8 update has introduced
some new checks. I’ll fix this and do the merge.
… <#m_250533183976321632_>
On Wed, 13 Sep 2023 at 19:46, Gerardo Roa Dabike *@*.*> wrote: Why have
these tests failed? This was just an update to various pre-commit hooks. I
checked the error for my PR and is because this message
notebooks/03_Running_the_CEC2_baseline_from_python.ipynb:cell_4:4:8: E721
do not compare types, for exact checks use > is / is not, for instance
checks use isinstance() Do i changed a type(cfg) == Docstring to
isinstance(cfg, Docstring) fixing the error — Reply to this email directly,
view it on GitHub <#338 (comment)
<#338 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACO7SJA6CBPSL3W2NHQXVBLX2H5RNANCNFSM6AAAAAA27TPL7E
<https://github.com/notifications/unsubscribe-auth/ACO7SJA6CBPSL3W2NHQXVBLX2H5RNANCNFSM6AAAAAA27TPL7E>
. You are receiving this because you commented.Message ID: @.*>
I did the fix and pushed it.
Now the pre-commit check passed
—
Reply to this email directly, view it on GitHub
<#338 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACO7SJFGMAXMN63JU6ACF5TX2NIHPANCNFSM6AAAAAA27TPL7E>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Professor Jon Barker,
Department of Computer Science,
University of Sheffield
+44 (0) 114 222 1824
|
Signed-off-by: Gerardo Roa Dabike <gerardo.roa@gmail.com>
Signed-off-by: Gerardo Roa Dabike <gerardo.roa@gmail.com>
keeping the numpy version lower than 1.25.0 "fixed" the issue. |
updates: