Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit-autoupdate #338

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Conversation

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc68482) 92.95% compared to head (a16e293) 92.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files          40       40           
  Lines        3778     3778           
=======================================
  Hits         3512     3512           
  Misses        266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 🤖

@ns-rse ns-rse added this pull request to the merge queue Aug 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2023
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 9f5b954 to 18bfd81 Compare August 8, 2023 09:11
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 18bfd81 to 163241c Compare August 15, 2023 09:38
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 09666da to 5304bd8 Compare August 29, 2023 09:14
@jonbarker68
Copy link
Contributor

Why have these tests failed? This was just an update to various pre-commit hooks.

updates:
- [github.com/asottile/pyupgrade: v3.9.0 → v3.10.1](asottile/pyupgrade@v3.9.0...v3.10.1)
- [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1)
- [github.com/DavidAnson/markdownlint-cli2: v0.8.1 → v0.9.2](DavidAnson/markdownlint-cli2@v0.8.1...v0.9.2)
- [github.com/pycqa/flake8.git: 6.0.0 → 6.1.0](https://github.com/pycqa/flake8.git/compare/6.0.0...6.1.0)
- [github.com/pre-commit/mirrors-mypy: v1.4.1 → v1.5.1](pre-commit/mirrors-mypy@v1.4.1...v1.5.1)
- [github.com/astral-sh/ruff-pre-commit: v0.0.280 → v0.0.288](astral-sh/ruff-pre-commit@v0.0.280...v0.0.288)
- [github.com/pycqa/pylint: v3.0.0a6 → v3.0.0a7](pylint-dev/pylint@v3.0.0a6...v3.0.0a7)
@groadabike
Copy link
Contributor

Why have these tests failed? This was just an update to various pre-commit hooks.

I checked the error for my PR and is because this message

notebooks/03_Running_the_CEC2_baseline_from_python.ipynb:cell_4:4:8: E721 do not compare types, for exact checks use > is / is not, for instance checks use isinstance()

Do i changed a type(cfg) == Docstring to isinstance(cfg, Docstring) fixing the error

@jonbarker68
Copy link
Contributor

jonbarker68 commented Sep 14, 2023 via email

Signed-off-by: Gerardo Roa Dabike <gerardo.roa@gmail.com>
@groadabike
Copy link
Contributor

groadabike commented Sep 14, 2023

Thanks. That makes sense. So basically the flake8 update has introduced some new checks. I’ll fix this and do the merge.

I did the fix and pushed it.
Now the pre-commit check passed

@jonbarker68
Copy link
Contributor

jonbarker68 commented Sep 15, 2023 via email

Signed-off-by: Gerardo Roa Dabike <gerardo.roa@gmail.com>
Signed-off-by: Gerardo Roa Dabike <gerardo.roa@gmail.com>
@groadabike
Copy link
Contributor

keeping the numpy version lower than 1.25.0 "fixed" the issue.
but, we still need to find what is the main problem

@groadabike groadabike added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit 1663f32 Sep 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants