Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed file so types can be used for users of mergedeep #2

Closed
RazerM opened this issue Jul 27, 2020 · 5 comments
Closed

Add py.typed file so types can be used for users of mergedeep #2

RazerM opened this issue Jul 27, 2020 · 5 comments

Comments

@RazerM
Copy link

RazerM commented Jul 27, 2020

See https://www.python.org/dev/peps/pep-0561/#id18

Without this, mypy won't type check mergedeep in code that uses it as a dependency:

error: Skipping analyzing 'mergedeep': found module but no type hints or library stubs
@WasabiFan
Copy link

It looks like this file is in the root of the repo rather than in the mergedeep module folder. Has anyone confirmed that type discovery for this module works right now? Initial indications in my project seem to suggest no.

@sshishov
Copy link

For me mypy is complaining actually that this package is not typed

@MicaelJarniac
Copy link

Mypy is also telling me that this project is not typed. I do also believe the py.typed file is in the wrong place.

@sshishov
Copy link

@clarketm could we please check this? Or do you need any help here?

@TomerGodinger
Copy link

Indeed, the py.typed file needs to be inside the mergedeep folder.
It would be nice if it was moved.

Is this library still being maintained? I see the last commits were made three years ago.

ericgj added a commit to ericgj/mergedeep that referenced this issue Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants