Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Item.set(string, value) and fix object merging bug #175

Closed
wants to merge 2 commits into from
Closed

Add support for Item.set(string, value) and fix object merging bug #175

wants to merge 2 commits into from

Conversation

aneilbaboo
Copy link
Contributor

Fixes #174

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 98.544% when pulling 8457eb2 on aneilbaboo:aneil/fixItemSet into df7acfe on clarkie:master.

@coveralls
Copy link

coveralls commented Jan 30, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 98.544% when pulling c9c4b1a on aneilbaboo:aneil/fixItemSet into df7acfe on clarkie:master.

@aneilbaboo
Copy link
Contributor Author

Closed in favor of #176. Will issue a separate PR to fix the object merging issue discussed in #174 once approach is finalized.

@aneilbaboo aneilbaboo closed this Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aneilbaboo @coveralls