Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove double negation from ast #17

Conversation

hardbyte
Copy link
Contributor

@hardbyte hardbyte commented Aug 28, 2023

Removes the DoubleMinus and DoubleNot from the AST.

Also after noting in the spec:

We only support positive, decimal integer literals; negative integers are produced by the unary negation operator.

I removed the -? before the integer and unsigned integer parsing.

One case is no longer handled correctly by the LARLPOP parser !!member. I've changed the test for now to !(!... hoping you know how to handle this properly?

Revised unary operations in AST, reduced to 'Not' & 'Neg' from 'Not', 'DoubleNot', 'Minus' & 'DoubleMinus', for simplifying the codebase.
@hardbyte hardbyte mentioned this pull request Aug 27, 2023
15 tasks
@clarkmcc
Copy link
Owner

Closing since this would cause a behavior regression in its current state. Can reopen in the future if needed

@clarkmcc clarkmcc closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants