-
Notifications
You must be signed in to change notification settings - Fork 147
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The wizards in `Clash.Xilinx.ClockGen` now use the user-provided name as the name of the /instance/ rather than the name of the /IP core/. This change was also done for Intel in PR #1022. When the user is responsible for creating the IP core/Qsys component, it makes sense to always set the component name to the user-provided value. But when that is also generated by Clash, that is no longer needed. Allowing users to set the instance name makes it possible to match on the instance in SDC files and such. Instead of always needing a user-specified name for the Intel and Xilinx PLL functions, the instance name can now be set through `Clash.Magic.setName`. To accomodate the changed function arguments, the functions are split into the deprecated old interface and a new interface which marks the use _unsafe_. This is expanded upon in the next commit.
- Loading branch information
1 parent
8cfc8ae
commit bce6c85
Showing
12 changed files
with
184 additions
and
207 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 12 additions & 1 deletion
13
clash-lib/prims/common/Clash_Xilinx_ClockGen.primitives.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 0 additions & 25 deletions
25
clash-lib/prims/commonverilog/Clash_Xilinx_ClockGen.primitives.yaml
This file was deleted.
Oops, something went wrong.
36 changes: 0 additions & 36 deletions
36
clash-lib/prims/vhdl/Clash_Xilinx_ClockGen.primitives.yaml
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.