Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BiSignal is not listed correctly in clash-manifest.json #1843

Closed
alex-mckenna opened this issue Jun 4, 2021 · 2 comments · Fixed by #1844
Closed

BiSignal is not listed correctly in clash-manifest.json #1843

alex-mckenna opened this issue Jun 4, 2021 · 2 comments · Fixed by #1844
Labels
bug

Comments

@alex-mckenna
Copy link
Contributor

BiSignalIn / BiSignalOut are used in clash to provide inout ports to an entity. In the manifest these should be listed as a single port with an inout direction. However, currently the BiSignalIn is listed as an in port (without it's domain) and the BiSignalOut is not listed at all.
@martijnbastiaan
Copy link
Member

without it's domain

Related: #1711

alex-mckenna pushed a commit that referenced this issue Jun 4, 2021
Show inout ports corerctly in clash-manifest.json
746c2a1 
When generating manifest files, any bidirectional ports would be
rendered as a single in port. This does not match the actual
port direction of the rendered HDL.

Fixes #1843
alex-mckenna pushed a commit that referenced this issue Jun 4, 2021
Show inout ports corerctly in clash-manifest.json
95378e3 
When generating manifest files, any bidirectional ports would be
rendered as a single in port. This does not match the actual
port direction of the rendered HDL.

Fixes #1843
alex-mckenna pushed a commit that referenced this issue Jun 4, 2021
Show inout ports correctly in clash-manifest.json
60d034d 
When generating manifest files, any bidirectional ports would be
rendered as a single in port. This does not match the actual
port direction of the rendered HDL.

Fixes #1843
@alex-mckenna alex-mckenna mentioned this issue Jun 4, 2021
Merged
2 tasks
@alex-mckenna
Copy link
Contributor Author

#1844 does not solve the issue of not showing the domain, but this is caused by the same thing as #1711, so this issue can be closed now that inout ports are rendered.

alex-mckenna pushed a commit that referenced this issue Jun 4, 2021
Show inout ports correctly in clash-manifest.json
4345604 
When generating manifest files, any bidirectional ports would be
rendered as a single in port. This does not match the actual
port direction of the rendered HDL.

Fixes #1843
alex-mckenna pushed a commit that referenced this issue Jun 4, 2021
@alex-mckenna
Show inout ports correctly in clash-manifest.json
86cb3b2 
When generating manifest files, any bidirectional ports would be
rendered as a single in port. This does not match the actual
port direction of the rendered HDL.

Fixes #1843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show inout ports correctly in clash-manifest.json clash-lang/clash-compiler
2 participants
@martijnbastiaan @alex-mckenna