Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trueDualPortBlockRam's goSlow and goFast don't account for X #2350

Closed
martijnbastiaan opened this issue Nov 7, 2022 · 1 comment
Closed

trueDualPortBlockRam's goSlow and goFast don't account for X #2350

martijnbastiaan opened this issue Nov 7, 2022 · 1 comment
Labels
bug

Comments

@martijnbastiaan
Copy link
Member

Specifically:

clash-compiler/clash-prelude/src/Clash/Explicit/BlockRam.hs

Line 1454 in 3c3e185

goSlow _ prevB | enA_ = out0 `seqX` (out0 :- as2, bs2)

and

clash-compiler/clash-prelude/src/Clash/Explicit/BlockRam.hs

Line 1466 in 3c3e185

goFast prevA _ | enB_ = out0 `seqX` (as2, out0 :- bs2)

If enA_ or enB_ are X, the output of the function will be.
@martijnbastiaan martijnbastiaan mentioned this issue Nov 7, 2022
Merged
5 tasks
martijnbastiaan added a commit that referenced this issue Mar 22, 2023
@martijnbastiaan
Generalize model implementation of 'trueDualPortBlockRam'
72a6e16 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
martijnbastiaan added a commit that referenced this issue Mar 22, 2023
@martijnbastiaan
Generalize model implementation of 'trueDualPortBlockRam'
8f33a30 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
martijnbastiaan added a commit that referenced this issue Mar 23, 2023
@martijnbastiaan
Generalize model implementation of 'trueDualPortBlockRam'
bbce7b8 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
martijnbastiaan added a commit that referenced this issue Mar 31, 2023
@martijnbastiaan
Generalize model implementation of 'trueDualPortBlockRam'
d6633f2 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
martijnbastiaan added a commit that referenced this issue Apr 11, 2023
@martijnbastiaan
Generalize model implementation of 'trueDualPortBlockRam'
96b8f4e 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
martijnbastiaan added a commit that referenced this issue Apr 12, 2023
@martijnbastiaan
Generalize model implementation of 'trueDualPortBlockRam'
a7ae2b0 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
martijnbastiaan added a commit that referenced this issue Apr 12, 2023
@martijnbastiaan
Generalize model implementation of 'trueDualPortBlockRam'
23e7221 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
martijnbastiaan added a commit that referenced this issue Apr 12, 2023
@martijnbastiaan
Generalize model implementation of 'trueDualPortBlockRam'
7e1d4e1 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
martijnbastiaan added a commit that referenced this issue Apr 12, 2023
@martijnbastiaan
Generalize model implementation of 'trueDualPortBlockRam'
9c2e821 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
DigitalBrains1 pushed a commit that referenced this issue Apr 13, 2023
@martijnbastiaan @DigitalBrains1
Generalize model implementation of 'trueDualPortBlockRam'
95107b0 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
martijnbastiaan added a commit that referenced this issue Apr 14, 2023
@martijnbastiaan
Generalize model implementation of 'trueDualPortBlockRam'
f9e7ec8 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350
martijnbastiaan added a commit that referenced this issue Apr 14, 2023
@martijnbastiaan @DigitalBrains1
Generalize model implementation of 'trueDualPortBlockRam'
926bd2a 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350

Co-authored-by: Peter Lebbing <peter@digitalbrains.com>
martijnbastiaan added a commit that referenced this issue Apr 14, 2023
@martijnbastiaan @DigitalBrains1
Generalize model implementation of 'trueDualPortBlockRam'
c57cc40 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350

Co-authored-by: Peter Lebbing <peter@digitalbrains.com>
martijnbastiaan added a commit that referenced this issue Apr 16, 2023
@martijnbastiaan @DigitalBrains1
Generalize model implementation of 'trueDualPortBlockRam'
fc609cf 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350

Co-authored-by: Peter Lebbing <peter@digitalbrains.com>
DigitalBrains1 added a commit that referenced this issue Apr 17, 2023
@martijnbastiaan @DigitalBrains1
Generalize model implementation of 'trueDualPortBlockRam'
6eb5a75 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350

Co-authored-by: Peter Lebbing <peter@digitalbrains.com>
martijnbastiaan added a commit that referenced this issue Apr 18, 2023
@martijnbastiaan @DigitalBrains1
Generalize model implementation of 'trueDualPortBlockRam'
2e7de3f 
Paves the way for adding a true dual port block RAM with byte enables to
`clash-cores`. It adds a new data type with smart constructors called
'MaybeX', which helps programmers deal with 'XException' in their
modelling code.

Fixes #2438
Fixes #2351
Fixes #2350

Co-authored-by: Peter Lebbing <peter@digitalbrains.com>
@christiaanb
Copy link
Member

We've released v1.8.0, which includes a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christiaanb @martijnbastiaan