Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compilePrimitive doesn't load module in special case #422

Closed
martijnbastiaan opened this issue Nov 21, 2018 · 0 comments
Closed

compilePrimitive doesn't load module in special case #422

martijnbastiaan opened this issue Nov 21, 2018 · 0 comments
Assignees
@martijnbastiaan
Labels
bug

Comments

@martijnbastiaan
Copy link
Member

See

clash-compiler/clash-lib/src/Clash/Driver.hs

Line 345 in 6dbf3b7

Hint.setImports [ "Clash.Netlist.BlackBox.Types", qualMod]
. It should use loadModule in order to prevent 'module not loaded errors'. We should also check if we omit loadModule in other places.
@martijnbastiaan martijnbastiaan self-assigned this Nov 21, 2018
@martijnbastiaan martijnbastiaan mentioned this issue Nov 21, 2018
Closed
martijnbastiaan added a commit that referenced this issue Nov 22, 2018
@martijnbastiaan
Try to import blackbox function in global and local module. Fix #422
322ad6d 
Hint offers no (obvious?) way to inspect which modules are present in
currently loaded package databases. As a consequence, we can't easily
detect whether we should explicitly load a (local) module of a blackbox
function or not. The implemented solution simply tries both and sees
approach one succeeds.
martijnbastiaan added a commit that referenced this issue Nov 22, 2018
@martijnbastiaan
Add crude tests for Haskell BlackBox functions
577b575 
Related issues:

 * #423
 * #422
martijnbastiaan added a commit that referenced this issue Nov 22, 2018
@martijnbastiaan
Add crude tests for Haskell BlackBox functions
aeb2a12 
Related issues:

 * #423
 * #422
martijnbastiaan added a commit that referenced this issue Nov 23, 2018
@martijnbastiaan
Add crude tests for Haskell BlackBox functions
7a649f6 
Related issues:

 * #423
 * #422
martijnbastiaan added a commit that referenced this issue Nov 28, 2018
@martijnbastiaan
Try to import blackbox function in global and local module. Fix #422
84858cf 
Hint offers no (obvious?) way to inspect which modules are present in
currently loaded package databases. As a consequence, we can't easily
detect whether we should explicitly load a (local) module of a blackbox
function or not. The implemented solution simply tries both and sees
approach one succeeds.
martijnbastiaan added a commit that referenced this issue Nov 28, 2018
@martijnbastiaan
Add crude tests for Haskell BlackBox functions
9c39b30 
Related issues:

 * #423
 * #422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martijnbastiaan martijnbastiaan

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martijnbastiaan