"Duplicate" names

[leonschoorl]

When compiled to VHDL this example has a port named unsignedField1 and generates an internal signal named \unsignedField1\.
I'm not sure what the VHDL spec says about escaped names, but Quartus 18.1 thinks those are the same and throws an error.
Vivado seems fine with it though.

module NamingClashes where
import Clash.Prelude

data SomeType = SomeType { boolField :: Bool, unsignedField :: (Unsigned 3) } deriving (Generic,NFDataX)
i = SomeType False 3


topEntity clk rst = withClockResetEnable clk rst enableGen $ mealy @System f i

{-# ANN topEntity
  (Synthesize { t_name = "NamingClashes"
              , t_inputs = [ PortName "clk", PortName "rst"
                           , PortProduct "" [ PortName "", PortName "unsignedField1"]
                           ]
              , t_output = PortName "result"
              }
  )#-}

f s x = (new,out)
  where
    SomeType _ unsignedField  = x
    new = s{unsignedField = succ unsignedField}
    out = unsignedField > 3

Workaround: compile with -fclash-no-escaped-identifiers

[christiaanb]

Line 165 on page 179 of the VHDL LRM says: "Moreover, every extended identifier is distinct from any basic identifier."

So quartus is broken

[martijnbastiaan]

If it's easy for us to do, I think we should not generate "duplicate" names. Even though it's not our fault, users might perceive Clash as broken due to this..

[christiaanb]

I propose -fclash-hdlsyn Quartus to enable such work-arounds.

[workshub]

This issue is now published on WorksHub. If you would like to work on this issue you can
start work on the WorksHub Issue Details page.

[workshub]

If you successfully complete this Issue via WorskHub there's a $25 reward available.
Start work via WorksHub Issue Details page.

[workshub]

@akilegaspi started working on this issue via WorksHub.

[christiaanb]

@akilegaspi I'll be removing this issue from workshub, as we're going to fix this ourselves. That is, unless you have something that fixes this issue.

[akilegaspi]

Please remove me from it, I haven't actually worked on it as I've expected; thanks.

…

On Thu, Mar 19, 2020 at 5:41 PM Christiaan Baaij ***@***.***> wrote: @akilegaspi <https://github.com/akilegaspi> I'll be removing this issue from workshub, as we're going to fix this ourselves. That is, unless you have something that fixes this issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#823 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABOKCUBI3FG3PEIHPCNJA5TRIHSF3ANCNFSM4I32PYDQ> .

[workshub]

@tensor1995 started working on this issue via WorksHub.

[martijnbastiaan]

@christiaanb Have you removed this issue from WorksHub?

[christiaanb]

don't reopen