funSubst works for all applications
#1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbastiaan
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Looks much better than before and I'm convinced this properly solves #1242.
I'm worried about the computational complexity of this function though. Due to the list for substitutions and the lookup for every variable, this works out to be O(n²). Then again, I guess we can assume these lists always stay tiny so the constant overhead of a hashmap might not be worth it. Nevertheless, something to keep in mind.
|
Almost forgot: add a CHANGELOG entry. |
Before, `funSubst`, the heart of our type-family resolution engine, could only deal with `a -> b` and `F a b` on both the matching side and argument side. Now it works on all applications, including things of the form `f a`. Fixes #1242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
funSubst, the heart of our type-family resolution engine, could only deal witha -> bandF a bon both the matching side and argument side. Now it works on all applications, including things of the formf a.Fixes #1242