Store configurations for known domains #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiaanb
requested changes
Jun 25, 2020
| knownConfs = filter (\x -> "KnownConf" == nameString (FamInstEnv.fi_fam x)) allTCInsts | ||
|
|
||
| #if MIN_VERSION_ghc(8,10,0) | ||
| fsToText = Text.pack . BS8.unpack . FastString.bytesFS |
There was a problem hiding this comment.
Suggested change
| fsToText = Text.pack . BS8.unpack . FastString.bytesFS | |
| fsToText = Data.Text.Encoding.decodeUtf8 . FastString.bytesFS |
| #if MIN_VERSION_ghc(8,10,0) | ||
| fsToText = Text.pack . BS8.unpack . FastString.bytesFS | ||
| #else | ||
| fsToText = Text.pack . BS8.unpack . BS.pack . FastString.bytesFS |
There was a problem hiding this comment.
Suggested change
| fsToText = Text.pack . BS8.unpack . BS.pack . FastString.bytesFS | |
| fsToText = Data.Text.Encoding.decodeUtf8 . FastString.fastStringToByteString |
alex-mckenna
force-pushed
the
domain-configuration-map
branch
from
26e7247
to
fc524bb
Compare
When loading modules, the domain configurations for all synthesis domains are extracted into a mapping from domain name to configuration. This will help remove some KnownDomain constraints later, and help with issues like #1387.
alex-mckenna
force-pushed
the
domain-configuration-map
branch
from
fc524bb
to
aefc0cf
Compare
|
Approved elsewhere; going ahead with merge |
Comment on lines
+511
to
+513
| asActiveEdge "Rising" = Rising | ||
| asActiveEdge "Falling" = Falling | ||
| asActiveEdge x = error $ $(curLoc) ++ "Unknown active edge: " ++ show x |
There was a problem hiding this comment.
No Read instances, and the error from Read is quite obtuse (*** Exception: Prelude.read: no parse)
There was a problem hiding this comment.
deriving Read + readMaybe? :)
There was a problem hiding this comment.
You've got me there, I'll make a small PR for it tomorrow 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading modules, the domain configurations for all synthesis
domains are extracted into a mapping from domain name to configuration.
This will help remove some KnownDomain constraints later, and help
with issues like #1387.