Add 0b prefix to Show output of BitVector
#1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbastiaan
changed the title
0b prefix to Show output of BitVector
This makes the rendered string a copyable expression for fully defined `BitVector`s. Related issue: #1773
martijnbastiaan
force-pushed
the
better-bv-show
branch
2 times, most recently
from
b4978dc
to
2181886
Compare
leonschoorl
reviewed
Apr 22, 2021
`Show` instance of `BitVector` already uses it
The new implementation doesn't require two consecutive reverses. Fixes: `show` on `BitVector 0` now produces a non-empty result
martijnbastiaan
force-pushed
the
better-bv-show
branch
from
2181886
to
de5ea81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.