Additions and fixes to Clash.Primitives.DSL
#2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbastiaan
force-pushed
the
primitive-dsl-changes
branch
from
2c217f9
to
33ad7d8
Compare
10 tasks
alex-mckenna
approved these changes
May 11, 2022
leonschoorl
reviewed
May 11, 2022
martijnbastiaan
force-pushed
the
primitive-dsl-changes
branch
5 times, most recently
from
6abec1d
to
6b8cbcc
Compare
Also deprecate it, as it's just an alias for fromBV
Instead of doing.. whatever it did before.
martijnbastiaan
force-pushed
the
primitive-dsl-changes
branch
2 times, most recently
from
c3c3810
to
65993ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me and @vmchale found a few bugs and missing functions in
Clash.Primitives.DSLover at #2182. This PR extracts the fixes we made.