Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsafe{From,To}Active{Low,High} #2540

Merged
merged 2 commits into from Jul 14, 2023
Merged

Add unsafe{From,To}Active{Low,High} #2540

merged 2 commits into from Jul 14, 2023

Conversation

martijnbastiaan
Copy link
Member

@martijnbastiaan martijnbastiaan commented Jul 13, 2023 •
edited

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files
  • Update references
  • Add unsafeToActive{Low,High}
  • Change deprecation message to indicate when the old functions get removed

@martijnbastiaan martijnbastiaan marked this pull request as draft July 13, 2023 13:57
@martijnbastiaan martijnbastiaan changed the title Add unsafeFromActiveLow and unsafeFromActiveHigh Add unsafe{From,To}Active{Low,High} Jul 13, 2023
@martijnbastiaan martijnbastiaan force-pushed the deprecate-from-polarity branch 2 times, most recently from de192fe to 3782597 Compare July 13, 2023 15:04
@martijnbastiaan martijnbastiaan marked this pull request as ready for review July 13, 2023 15:05
@leonschoorl leonschoorl mentioned this pull request Jul 14, 2023
Merged
3 tasks
leonschoorl
leonschoorl approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@leonschoorl leonschoorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ the new names, always thought the polarity terminology was odd

@martijnbastiaan martijnbastiaan merged commit 897a16f into master Jul 14, 2023
13 checks passed
@martijnbastiaan martijnbastiaan deleted the deprecate-from-polarity branch July 14, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DigitalBrains1 DigitalBrains1 DigitalBrains1 left review comments

@leonschoorl leonschoorl leonschoorl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martijnbastiaan @leonschoorl @DigitalBrains1