Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KnownNat (DomainPeriod dom) to KnownDomain #2541

Merged
merged 1 commit into from Jul 14, 2023
Merged

Add KnownNat (DomainPeriod dom) to KnownDomain #2541

merged 1 commit into from Jul 14, 2023

Conversation

martijnbastiaan
Copy link
Member

@martijnbastiaan martijnbastiaan commented Jul 13, 2023 •
edited

We previously needed to either:

  • Add this constraint to our functions
  • Match on the SNat produced by clockPeriod @dom

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

@martijnbastiaan martijnbastiaan mentioned this pull request Jul 14, 2023
Merged
lmbollen
lmbollen approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@lmbollen lmbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the typo-fix from this PR and then merge.

christiaanb
christiaanb approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@christiaanb christiaanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changelog/2023-07-13T20_31_20+02_00_add_knownnat_period Outdated Show resolved Hide resolved
@martijnbastiaan martijnbastiaan enabled auto-merge (squash) July 14, 2023 15:10
@martijnbastiaan martijnbastiaan merged commit 8702bad into master Jul 14, 2023
13 checks passed
@martijnbastiaan martijnbastiaan deleted the knowndomain-constraints branch July 14, 2023 16:09
NadiaYvette pushed a commit to NadiaYvette/clash-compiler that referenced this pull request Jul 30, 2023
@martijnbastiaan @NadiaYvette
Add KnownNat (DomainPeriod dom) to KnownDomain (clash-lang#2541)
dff2ec6
@martijnbastiaan martijnbastiaan mentioned this pull request Sep 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DigitalBrains1 DigitalBrains1 DigitalBrains1 left review comments

@christiaanb christiaanb christiaanb approved these changes

@lmbollen lmbollen lmbollen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martijnbastiaan @christiaanb @DigitalBrains1 @lmbollen