Revert vector pattern "fixes" #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commits: * 338558a * e6872e9 * d7f4e48 * 1b1d03c * 0db9192 * bf453ae * 060ce16 We found too many issues with exporting the "real" vector constructor: 1. While it improves type inference in some cases (see issue #867), it worsens it in others. (See testsuite changes in #943.) 2. GADT don't permit lazy patterns, which seems to be widely used in existing code bases. 3. Using the Vec constructor can trigger a bug in GHC stochastically making compilation _super_ slow. Having it as a default is therefore not ideal for now.
|
We are exporting also exporting the real vector constructor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commits:
We found too many issues with exporting the "real" vector constructor:
While it improves type inference in some cases (see issue View pattern definition of :> doesn't play nicely with typechecker #867), it
worsens it in others. (See testsuite changes in Remove :> pattern, rename Cons to :> #943.)
GADT don't permit lazy patterns, which seems to be widely used in
existing code bases.
Using the Vec constructor can trigger a bug in GHC stochastically
making compilation super slow. Having it as a default is therefore
not ideal for now.